Skip to content

Commit daa8869

Browse files
Merge pull request #3761 from RosarioPulella/fix-local-release-build
Fix Visual studio release build
2 parents 4dc90dc + f7bf580 commit daa8869

File tree

7 files changed

+54
-49
lines changed

7 files changed

+54
-49
lines changed

Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -495,6 +495,8 @@
495495
<Compile Include="SamplePages\ColorPicker\ColorPickerPage.xaml.cs">
496496
<DependentUpon>ColorPickerPage.xaml</DependentUpon>
497497
</Compile>
498+
<Compile Include="SamplePages\EnumValuesExtension\Animal.cs" />
499+
<Compile Include="SamplePages\EnumValuesExtension\AnimalToColorConverter.xaml.cs" />
498500
<Compile Include="SamplePages\EnumValuesExtension\EnumValuesExtensionPage.xaml.cs">
499501
<DependentUpon>EnumValuesExtensionPage.xaml</DependentUpon>
500502
</Compile>

Microsoft.Toolkit.Uwp.SampleApp/Models/Sample.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
using System.Text.Json.Serialization;
1717
using System.Text.RegularExpressions;
1818
using System.Threading.Tasks;
19+
1920
// TODO Reintroduce graph controls
2021
// using Microsoft.Toolkit.Graph.Converters;
2122
// using Microsoft.Toolkit.Graph.Providers;

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/CanvasPathGeometry/CanvasPathGeometryPage.xaml.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ public sealed partial class CanvasPathGeometryPage : Page
9595
private Color _strokeColor;
9696
private Color _fillColor;
9797
private bool _selectionChanged = false;
98-
private bool _isParsing = false;
9998

10099
private CanvasGeometry _errorGeometry;
101100
private GeometryStreamReader _reader;
@@ -172,9 +171,7 @@ public CanvasPathGeometryPage()
172171
private void ParseData()
173172
{
174173
_data = InputData.Text;
175-
_isParsing = true;
176174
RenderCanvas.Invalidate();
177-
_isParsing = false;
178175
}
179176

180177
private void OnCanvasDraw(CanvasControl sender, CanvasDrawEventArgs args)
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
// Licensed to the .NET Foundation under one or more agreements.
2+
// The .NET Foundation licenses this file to you under the MIT license.
3+
// See the LICENSE file in the project root for more information.
4+
5+
namespace Microsoft.Toolkit.Uwp.SampleApp.Enums
6+
{
7+
public enum Animal
8+
{
9+
Cat,
10+
Dog,
11+
Bunny,
12+
Parrot,
13+
Squirrel
14+
}
15+
}
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
// Licensed to the .NET Foundation under one or more agreements.
2+
// The .NET Foundation licenses this file to you under the MIT license.
3+
// See the LICENSE file in the project root for more information.
4+
5+
using System;
6+
using Microsoft.Toolkit.Uwp.SampleApp.Enums;
7+
using Windows.UI;
8+
using Windows.UI.Xaml.Data;
9+
10+
namespace Microsoft.Toolkit.Uwp.SampleApp.Converters
11+
{
12+
public sealed class AnimalToColorConverter : IValueConverter
13+
{
14+
public object Convert(object value, Type targetType, object parameter, string language)
15+
{
16+
return (Animal)value switch
17+
{
18+
Animal.Cat => Colors.Coral,
19+
Animal.Dog => Colors.Gray,
20+
Animal.Bunny => Colors.Green,
21+
Animal.Parrot => Colors.YellowGreen,
22+
Animal.Squirrel => Colors.SaddleBrown,
23+
_ => throw new ArgumentException("Invalid value", nameof(value))
24+
};
25+
}
26+
27+
public object ConvertBack(object value, Type targetType, object parameter, string language)
28+
{
29+
throw new NotImplementedException();
30+
}
31+
}
32+
}

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/EnumValuesExtension/EnumValuesExtensionPage.xaml.cs

Lines changed: 2 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,8 @@
22
// The .NET Foundation licenses this file to you under the MIT license.
33
// See the LICENSE file in the project root for more information.
44

5-
using System;
6-
using Microsoft.Toolkit.Uwp.SampleApp.Enums;
7-
using Windows.UI;
5+
using Microsoft.Toolkit.Uwp.UI;
86
using Windows.UI.Xaml;
9-
using Windows.UI.Xaml.Data;
107

118
namespace Microsoft.Toolkit.Uwp.SampleApp.SamplePages
129
{
@@ -27,43 +24,4 @@ public void OnXamlRendered(FrameworkElement control)
2724
{
2825
}
2926
}
30-
}
31-
32-
#pragma warning disable SA1403 // File may only contain a single namespace
33-
namespace Microsoft.Toolkit.Uwp.SampleApp.Enums
34-
{
35-
public enum Animal
36-
{
37-
Cat,
38-
Dog,
39-
Bunny,
40-
Parrot,
41-
Squirrel
42-
}
43-
}
44-
45-
namespace Microsoft.Toolkit.Uwp.SampleApp.Converters
46-
{
47-
public sealed class AnimalToColorConverter : IValueConverter
48-
{
49-
public object Convert(object value, Type targetType, object parameter, string language)
50-
{
51-
return (Animal)value switch
52-
{
53-
Animal.Cat => Colors.Coral,
54-
Animal.Dog => Colors.Gray,
55-
Animal.Bunny => Colors.Green,
56-
Animal.Parrot => Colors.YellowGreen,
57-
Animal.Squirrel => Colors.SaddleBrown,
58-
_ => throw new ArgumentException("Invalid value", nameof(value))
59-
};
60-
}
61-
62-
public object ConvertBack(object value, Type targetType, object parameter, string language)
63-
{
64-
throw new NotImplementedException();
65-
}
66-
}
67-
}
68-
69-
#pragma warning restore SA1403
27+
}

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/ViewportBehavior/ViewportBehaviorPage.xaml.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ private void ClearLogsButton_Click(object sender, RoutedEventArgs e)
6767
_logs.Clear();
6868
}
6969

70-
private async void EffectElementHost_EnteredViewport(object sender, EventArgs e)
70+
private void EffectElementHost_EnteredViewport(object sender, EventArgs e)
7171
{
7272
AddLog("Entered viewport");
7373

@@ -81,7 +81,7 @@ private void EffectElementHost_EnteringViewport(object sender, EventArgs e)
8181
_effectElement.Source = new BitmapImage(new Uri("ms-appx:///Assets/ToolkitLogo.png"));
8282
}
8383

84-
private async void EffectElementHost_ExitedViewport(object sender, EventArgs e)
84+
private void EffectElementHost_ExitedViewport(object sender, EventArgs e)
8585
{
8686
AddLog("Exited viewport");
8787

0 commit comments

Comments
 (0)