🚧 DRAFT: Correct ancestor XAML memory leak #4187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the design when some tabs are hidden
This fixes potential issues with shared instances of the brush
…Toolkit-1 into feature/control-width-trigger
…Toolkit-1 into feature/control-width-trigger
…-named-generated-property Fixed [ObservableProperty] for fields named "value"
…mboBoxColumn.cs Co-authored-by: Rosario Pulella <[email protected]>
…lick-fix Improving ComboBoxColumn behavior to prevent triple click behavior
…zingtextbox-header-fix Fix TokenizingTextBox header to behave like normal text control headers
…#4206) <!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 --> <!-- 👉 It is imperative to resolve ONE ISSUE PER PR and avoid making multiple changes unless the changes interrelate with each other --> <!-- 📝 Please always keep the "☑️ Allow edits by maintainers" button checked in the Pull Request Template as it increases collaboration with the Toolkit maintainers by permitting commits to your PR branch (only) created from your fork. This can let us quickly make fixes for minor typos or forgotten StyleCop issues during review without needing to wait on you doing extra work. Let us help you help us! 🎉 --> ### Note: This is a copy of the previously reviewed work with a new branch name ## Fixes CommunityToolkit#2493 <!-- Add the relevant issue number after the "#" mentioned above (for ex: "## Fixes CommunityToolkit#1234") which will automatically close the issue once the PR is merged. --> <!-- Add a brief overview here of the feature/bug & fix. --> This prevents DataGrid from assuming focus should be reset back to itself when a control inside DataGridTemplateColumn gains focus. This is my first WCT PR, so please go easy on me 😆 ## PR Type What kind of change does this PR introduce? <!-- Please uncomment one or more options below that apply to this PR. --> Bugfix <!-- - --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Trying to open a control like CalendarDatePicker from within a DataGridTemplateColumn doesn't work, as there is specific behavior to detect when DataGrid loses focus and return it. This doesn't make much sense for controls which require focus to function properly. ## What is the new behavior? <!-- Describe how was this issue resolved or changed? --> When the DataGrid loses focus, we now specifically detect if the editing column is a DataGridTemplateColumn and alter the behavior to accommodate this. ## PR Checklist Please check if your PR fulfills the following requirements: - [x] Tested code with current [supported SDKs](../readme.md#supported) - [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link --> - [ ] Sample in sample app has been added / updated (for bug fixes / features) - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/CommunityToolkit/WindowsCommunityToolkit-design-assets) - [ ] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/CommunityToolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc... - [ ] Tests for the changes have been added (for bug fixes / features) (if applicable) - [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*) - [x] Contains **NO** breaking changes <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. --> ## Other information I'm unsure if this is the *best* way to do this, but it makes the most sense given how DataGrid already has the capability to detect the editing element and column type. Additional context before branch rename: CommunityToolkit#4206 Related: unoplatform/uno#6543
…st-winui-version UITests: Remove ref to incorrect version of winui
…-toolkit-sg Fix and enable MVVM Toolkit source generator unit tests
…ment layout changes and visibility changes
…-tools Convert `DesignTools` projects to Sdk-style
…rp-version-diagnostic Add C# language version diagnostic
|
|
||
| treeRoot.Unloaded += (sender, e) => | ||
| { | ||
| Assert.AreEqual(grid, null); |
Member
There was a problem hiding this comment.
Wonder if this is getting called late and causing a problem as immediately after this the test ends...
We're also waiting for the Unloaded event from the content itself as part of the VisualUITestBase Cleanup method, so we may need to try forcing your content to unload first before letting the test end?
Maybe try calling await SetTestContentAsync(null) after this? The Clean-up method also shows using a TaskCompletionSource too which we could use to await the event to ensure we got the unloaded callback and the assert is checked.
…vents Fix CommunityToolkit#4214 - Update AttachedDropShadow visual on layout/visibility
…diog/ToCompositionString Prevent floats from being represented in scientific notation in expression animation strings
…to local/AncestorTheUnloaded
8 tasks
Contributor
Author
|
This PR closed, and relevant bits moved to #4236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CommunityToolkit/Windows#107
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Steps to Reproduce:
TokenizingTextBox, for example)What is the new behavior?
The elements should be freed.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information