update mzdata to 0.48.3
#4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the version of
mzdatato 0.48.3, which includes more robust parsing of mzML metadata. Compared to the current version, this makes "invalid" values that aren't related to the integrity of spectra and signals warnings, not fatal errors.It also attempts to make use of the ion mobility accessors that handle things other than timsTOF ion mobility measures. I saw you are handling some other non-standard names, but I don't recognize their origin.
I noticed that you use an unsigned integer type for charge state. In principle, that could lead to overflow when converting a signed integer to unsigned, so I also added an
abscall prior to conversion to avoid catastrophic wrap around.