Skip to content

Conversation

@O-Bots
Copy link
Collaborator

@O-Bots O-Bots commented Nov 7, 2025

Changes:

  • Added playwright config file
  • Setup playwright reporting
  • Added playwright scripts to the package.json
  • Moved original "some.test" file to new folder structure (tests/e2e/web/specs)
  • Deleted original playwright folder (tests/playwright)

@MartinBraquet Review this when you get a chance.

@vercel
Copy link

vercel bot commented Nov 7, 2025

@O-Bots is attempting to deploy a commit to the Compass Team on Vercel.

A member of the Team first needs to authorize it.

@MartinBraquet
Copy link
Member

To make the tests pass, you'll need to update this to the correct folder
https://github.com/CompassConnections/Compass/blob/main/.github/workflows/ci.yml#L57C1-L57C47
Also let's use dev for now so it passes? Set NEXT_PUBLIC_FIREBASE_ENV: DEV in the same file
You can then check locally all the command lines that the CI runs to confirm:

          yarn --cwd=web serve &
          npx wait-on http://localhost:3000
          npx playwright test tests/e2e # change dir here
          SERVER_PID=$(fuser -k 3000/tcp)
          echo $SERVER_PID
          kill $SERVER_PID

Lmk how it goes!

@MartinBraquet MartinBraquet self-requested a review November 7, 2025 18:49
@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
compass Ready Ready Preview Comment Nov 7, 2025 9:53pm

@MartinBraquet MartinBraquet merged commit 1293523 into CompassConnections:main Nov 7, 2025
1 of 2 checks passed
@MartinBraquet
Copy link
Member

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants