Add firebase emulator, Add registration script, Add signup spec #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@n3c777 is attempting to deploy a commit to the Compass Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Works great with I fix the emulator and made the tests pass. Lmk if you'd like to do other things in this PR. I think we could merge it soon if that looks good to you, so as to secure the good current state of the tests and emulator. |
# Conflicts: # scripts/e2e.sh
| export const auth = getAuth(app) | ||
|
|
||
| if (IS_FIREBASE_EMULATOR) { | ||
| connectAuthEmulator(auth, 'http://127.0.0.1:9099', { disableWarnings: true }) |
Member
There was a problem hiding this comment.
This was one key missing line.
Comment on lines
+27
to
+28
| export FIREBASE_AUTH_EMULATOR_HOST=127.0.0.1:9099 | ||
| export FIREBASE_STORAGE_EMULATOR_HOST=127.0.0.1:9199 |
Member
There was a problem hiding this comment.
This may also have been one key missing line.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
|
CI test (which includes E2E) just passed on github—great! |
MartinBraquet
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr includes a few components.
Registration script registers a user through frirebase auth using the emulator. This should be ran along with userCreation.ts. In the future these two need to be further synchronized as userCreation will need the ID created from setup-auth.
Signup spec registers a user then uses the deleteUserFixture to delete the user.
Firebase emulator is mainly a modification of firebase.json and init-admin.ts. It will make future e2e testing a lot easier. However in its current form it isn't working.