Feature/improve ismodel type safety#20
Merged
othercodes merged 2 commits intomainfrom Oct 13, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces improved type safety and modern best practices for the Complex Heart domain modeling library by implementing a type-safe make() factory method with automatic invariant checking.
- Implements type-safe factory method with runtime validation and clear error messages
- Adds automatic invariant checking for Value Objects and Entities when using
make() - Updates documentation to promote modern approaches over legacy patterns
- Refactors test structure with improved organization and comprehensive coverage
Reviewed Changes
Copilot reviewed 35 out of 40 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/IsModel.php | Complete rewrite adding type-safe make() factory with parameter validation and auto-check functionality |
| src/IsValueObject.php | Enables automatic invariant checking by default for Value Objects |
| src/IsEntity.php | Enables automatic invariant checking by default for Entities |
| wiki/*.md | Updates documentation to promote make() factory over direct constructor calls |
| tests/TypeValidationTest.php | New comprehensive test suite for type validation features |
| tests/AutoCheckInvariantsTest.php | New test suite for automatic invariant checking functionality |
| tests/Fixtures/TypeSafety/* | New test fixtures for type safety validation scenarios |
| tests/Fixtures/OrderManagement/* | Namespace reorganization from Test\OrderManagement to Test\Fixtures\OrderManagement |
| composer.json | Adds Laravel Pint for code formatting and increases PHPStan memory limit |
| README.md | Updates with key features and usage notes for the new factory method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
othercodes
force-pushed
the
feature/improve-ismodel-type-safety
branch
from
c024c5c to
03edc65
Compare
othercodes
force-pushed
the
feature/improve-ismodel-type-safety
branch
from
03edc65 to
ae3a170
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.