Feature/Add support for union types in IsModel trait#21
Merged
othercodes merged 1 commit intomainfrom Oct 13, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for union types in the IsModel trait, enabling the make() method to properly validate parameters that accept multiple types (e.g., int|float|string).
- Added union type validation logic in the
validateConstructorParametersmethod - Introduced a new
validateUnionTypemethod to handle complex type checking - Updated error messages and type imports for better consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/IsModel.php | Core implementation of union type support with validation logic and error handling |
| tests/Fixtures/TypeSafety/FlexibleValue.php | Test fixture class demonstrating union types with int|float|string and nullable parameters |
| tests/TypeValidationTest.php | Comprehensive test coverage for union type scenarios including error cases and nullable types |
Comments suppressed due to low confidence (1)
tests/TypeValidationTest.php:1
- The
__toString()method returns$this->labelwhen it's not null, but the test on line 101 expects the string representation to be '42', not 'Label'. This will cause the test to fail when a label is provided.
<?php
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.