Skip to content

Conversation

@xiaojiey
Copy link
Collaborator

@xiaojiey xiaojiey commented Jan 4, 2026

The previous fix in PR #806 accidently got removed. This PR is the same with PR #806

@openshift-ci-robot
Copy link
Collaborator

@xiaojiey: This pull request references CMP-3563 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The previous fix in PR #806 removed the user_setup script that made
/etc/passwd group-writable (664), but Docker layer caching could still
result in 664 permissions in the final image.

This change adds an explicit RUN chmod 644 /etc/passwd command to all
Dockerfiles to ensure correct permissions regardless of cached layers
or base image state.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1036-25835ae63bc078b6dc0baa209d0db7883f9a32cc

@xiaojiey xiaojiey changed the title CMP-3563: Explicitly set /etc/passwd permissions to 644 CMP-3563: Modernize user setup Jan 4, 2026
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1036-735c43d18a7916f633f70c71abbb04c3158e16b3

@xiaojiey
Copy link
Collaborator Author

xiaojiey commented Jan 4, 2026

With CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1036-735c43d18a7916f633f70c71abbb04c3158e16b3, I can see the /etc/passwd permission is correct now:

$ oc get csv
NAME                             DISPLAY               VERSION     REPLACES   PHASE
compliance-operator.v1.8.0-dev   Compliance Operator   1.8.0-dev              Succeeded
$ oc get pod
NAME                                              READY   STATUS     RESTARTS      AGE
compliance-operator-6f6fdd6485-z6qpm              1/1     Running    2 (71s ago)   75s
ocp4-openshift-compliance-pp-7966b4f478-lmfxc     1/1     Running    0             54s
rhcos4-openshift-compliance-pp-64b955dc6b-sqtb9   0/1     Init:1/2   0             54s
$ oc exec pod/compliance-operator-6f6fdd6485-z6qpm -- ls -ltr /etc/passwd
-rw-r--r--. 1 root root 591 Jan  4 07:57 /etc/passwd

@xiaojiey
Copy link
Collaborator Author

xiaojiey commented Jan 5, 2026

/retest

@yuumasato yuumasato self-assigned this Jan 5, 2026
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 5, 2026
@yuumasato yuumasato added this to the 1.9.0 milestone Jan 5, 2026
@yuumasato
Copy link
Member

/retest

1 similar comment
@yuumasato
Copy link
Member

/retest

@yuumasato
Copy link
Member

/test e2e-aws-serial

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaojiey, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuumasato yuumasato changed the title CMP-3563: Modernize user setup CMP-3665: Modernize user setup Jan 7, 2026
@openshift-ci-robot
Copy link
Collaborator

@xiaojiey: This pull request references CMP-3665 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The previous fix in PR #806 accidently got removed. This PR is the same with PR #806

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yuumasato yuumasato changed the title CMP-3665: Modernize user setup CMP-3635: Modernize user setup Jan 7, 2026
@openshift-ci-robot
Copy link
Collaborator

@xiaojiey: This pull request references CMP-3635 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the vulnerability to target either version "4.22." or "openshift-4.22.", but it targets "compliance-operator-1.9.0" instead.

Details

In response to this:

The previous fix in PR #806 accidently got removed. This PR is the same with PR #806

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xiaojiey
Copy link
Collaborator Author

xiaojiey commented Jan 9, 2026

/label qe-approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants