chore:[CPLYTM-628] add sync oscal to cac #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiwangredhat
changed the title
huiwangredhat
force-pushed
the
sync_oscal_to_cac
branch
6 times, most recently
from
049d86a to
4e55791
Compare
huiwangredhat
requested review from
a team,
AlexXuan233,
hbraswelrh and
marcusburghardt
huiwangredhat
force-pushed
the
sync_oscal_to_cac
branch
from
4e55791 to
cc68ff4
Compare
huiwangredhat
force-pushed
the
sync_oscal_to_cac
branch
from
cc68ff4 to
7809f26
Compare
Signed-off-by: Sophia Wang <huiwang@redhat.com>
huiwangredhat
force-pushed
the
sync_oscal_to_cac
branch
2 times, most recently
from
307c263 to
7063f70
Compare
AlexXuan233
reviewed
Apr 29, 2025
huiwangredhat
force-pushed
the
sync_oscal_to_cac
branch
from
7063f70 to
024765a
Compare
AlexXuan233
reviewed
Apr 29, 2025
huiwangredhat
force-pushed
the
sync_oscal_to_cac
branch
2 times, most recently
from
3c20ec2 to
136fc3c
Compare
hbraswelrh
approved these changes
May 6, 2025
hbraswelrh
left a comment
hbraswelrh
left a comment
There was a problem hiding this comment.
LGTM. I left a couple comments. The test reference provided looks great.
huiwangredhat
force-pushed
the
sync_oscal_to_cac
branch
from
136fc3c to
87f9991
Compare
Signed-off-by: Sophia Wang <huiwang@redhat.com>
huiwangredhat
force-pushed
the
sync_oscal_to_cac
branch
from
87f9991 to
e9d5e22
Compare
Collaborator
Author
|
Move it to the draft to hide it in the review list. Since it is no need to review again and it is not meaningful to merge it before moving it to the CAC org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sync oscal->cac. It pairs with the PR for sync cac->oscal .
The test detail:
https://github.com/complytime/oscal-content/actions/runs/14698768504/job/41244469626
The created_pr in cac content is here.