-
Notifications
You must be signed in to change notification settings - Fork 11
Release 1.5.1 #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.5.1 #203
Conversation
(cherry picked from commit 273e8ed)
(cherry picked from commit e7de2b9)
fix build scripts (cherry picked from commit 244d9e3)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 541e02d)
…1.10.2 (cherry picked from commit d94e07d)
(cherry picked from commit 55ee17d)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 60ee921)
(cherry picked from commit d5750d1)
(cherry picked from commit e8f85b9)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 0801c75)
(cherry picked from commit af205a2)
(cherry picked from commit 41a42e5)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit df63564)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @egorikftp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a comprehensive update aimed at preparing the project for its 1.5.1 release. It involves significant dependency upgrades, the implementation of a new centralized versioning system, and various build system improvements. Additionally, it includes minor API adjustments and a thorough refresh of the project's documentation.
Highlights
- Release Preparation & Dependency Updates: This pull request updates numerous core dependencies, including Android Gradle Plugin (AGP) to 8.9.3, Jetpack Compose to 1.8.2, and Kotlin to 2.2.0, in preparation for the 1.5.1 release. Other AndroidX, Detekt, Koin, and Coroutines dependencies have also been bumped to their latest versions.
- Centralized Version Management: A new
libConfig.tomlfile has been introduced to centralize version definitions fortiamat-core,tiamat-koin, andtiamat-destinations(all set to 1.5.1). This new version catalog is now used across all relevantbuild.gradle.ktsfiles, streamlining version management. - Build System & Compiler Plugin Enhancements: Gradle build scripts have been refined to improve
cleantask handling for included builds and to dynamically generate aBuildConfig.ktfile for the compiler plugin, ensuring the compiler plugin uses the correct version from the centralized configuration. TheM2Pplugin configuration has also been simplified. - API Adjustments & Example Updates: Minor API changes have been made in the
tiamatandtiamat-destinationslibraries, such as renaming thestateparameter tosharedContentStateinModifier.sharedElementand modifying interface method modifiers. The example app'sbuild.gradle.ktswas updated for Kotlin/WASM DSL changes and removed unused AndroidX UI tooling dependencies. - Documentation Refresh: The
README.mdhas received a significant overhaul, featuring a revised header, new badges for social channels and WASM demo, an updated Maven dependency table using a new badge syntax, and a corrected copyright year (2025).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares for the 1.5.1 release by updating dependencies, centralizing version management into libConfig.toml, and refactoring the build and publishing logic. These are excellent improvements for maintainability. The compiler plugin has been made more robust, and tests have been enhanced for better verification.
I've identified a critical issue in the Gradle plugin's publishing configuration that needs to be addressed to ensure a successful release. I've also provided a few medium-severity suggestions to improve the clarity of the README and test code. Overall, this is a solid PR.
...src/test/kotlin/com/composegears/tiamat/destinations/TiamatDestinationsCompilerPluginTest.kt
Outdated
Show resolved
Hide resolved
...src/test/kotlin/com/composegears/tiamat/destinations/TiamatDestinationsCompilerPluginTest.kt
Outdated
Show resolved
Hide resolved
2e65630 to
dbb55e0
Compare
Change log:
Dependencies
2.1.20->2.2.21.7.3->1.8.2