Skip to content

Fix #344 unregistered destinations might be opened in navigation #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vkatz merged 2 commits into from
Feb 11, 2026
Merged

Fix #344 unregistered destinations might be opened in navigation #347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af4fe4c
Fix unregistered destinations might be opened in navigation
vkatz Feb 8, 2026
a643885
fix detekt
vkatz Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tiamat/src/commonMain/kotlin/com/composegears/tiamat/compose/ComposableNavigation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ public fun NavigationScene(
* @param scene Scene builder composable function that defines how navigation entries are rendered
*/
@Composable
@Suppress("CognitiveComplexMethod")
@Suppress("CognitiveComplexMethod", "MaximumLineLength", "MaxLineLength")
public fun NavigationScene(
navController: NavController,
destinationResolver: (name: String) -> NavDestination<*>?,
Expand Down Expand Up @@ -278,8 +278,12 @@ public fun NavigationScene(
if (!entry.isResolved) entry.resolveDestination(destinationResolver)
NavEntryContent(entry)
DisposableEffect(entry) {
if (visibleEntries.contains(entry))
error("The same entry (${entry.destination.name}) should not be displayed twice")
if (destinationResolver(entry.destination.name) == null) error(
"NavController: ${navController.key}, the destination (${entry.destination.name}) is not registered in Navigation"
)
if (visibleEntries.contains(entry)) error(
"NavController: ${navController.key}, the same entry (${entry.destination.name}) should not be displayed twice"
)
visibleEntries.add(entry)
onDispose {
visibleEntries.remove(entry)
Expand Down