openPMD plugin: optimized restart from partial domain #5582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
force-pushed
the
dont-use-remap-buffer
branch
from
132ecb3 to
3690da4
Compare
psychocoderHPC
previously requested changes
Jan 5, 2026
Member
psychocoderHPC
left a comment
psychocoderHPC
left a comment
There was a problem hiding this comment.
Only reformating of the comments is required
psychocoderHPC
added
the
refactoring
PrometheusPi
previously approved these changes
Jan 5, 2026
Member
PrometheusPi
left a comment
PrometheusPi
left a comment
There was a problem hiding this comment.
looks fine to me - but please follow @psychocoderHPC suggestions regarding moving comments
| { | ||
| continue; | ||
| } | ||
| dataPtr[remap[particleIndex]] = dataPtr[particleIndex]; |
Member
There was a problem hiding this comment.
This looks like magic to me and a find the new version much clearer.
Contributor
Author
There was a problem hiding this comment.
The major change is that the previous version (unnecessarily) precomputed the target indices. Could have been made a bit clearer by:
auto previouslyComputedNewIndex = remap[particleIndex];
dataPtr[previouslyComputedNewIndex] = dataPtr[particleIndex];
PrometheusPi
approved these changes
Jan 5, 2026
PrometheusPi
dismissed
psychocoderHPC’s stale review
all requests have been fullfiled
PrometheusPi
merged commit 450b8b3
into
ComputationalRadiationPhysics:dev
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5508, that PR used a needless precomputed intermediate buffer
remap. Not included in that PR to avoid last-minute changes/errors.