openPMD-api: raise minimum required version to 0.17#5613
Draft
franzpoeschel wants to merge 11 commits intoComputationalRadiationPhysics:devfrom
Draft
openPMD-api: raise minimum required version to 0.17#5613franzpoeschel wants to merge 11 commits intoComputationalRadiationPhysics:devfrom
franzpoeschel wants to merge 11 commits intoComputationalRadiationPhysics:devfrom
Conversation
19b5d83 to
d92d5d4
Compare
Member
|
@franzpoeschel regarding your first statement:
What time frame for making this mainline do you envision? |
Contributor
Author
Discussed with @psychocoderHPC in the last dev meeting: Some time halfway between now and the next PIConGPU release. Probably before/around summer break or so.
The CI also runs on draft PRs, right? |
Member
|
Yes, even in draft mode, the CI still checks the code. |
Member
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not be immediately merged, users should have some time to upgrade.
PR implements the following new features:
RecordComponent::SCALARhas been discarded (need to scan for usage in other places / other plugins again though)--openPMD.tomlnow allows specifying openPMD backend options in TOML format, it is no longer needed to give them as a JSON string within TOMLTODO:
RecordComponent::SCALAR--openPMD.toml