Skip to content

Major Project History on Dashboard #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Major Project History on Dashboard #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions conditional/blueprints/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ def display_dashboard():
'status': p.status,
'description': p.description
} for p in
MajorProject.query.filter(MajorProject.uid == member.uid,
MajorProject.date > start_of_year())]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashboard is meant to display information pertaining to the current evaluations period. With that said, I am not against showing history here, but it should be shown in the proper context. We should either change the styling of past year's major projects (grey them out, etc.) or put them in a new table called "Past Projects" or something of the like.

MajorProject.query.filter(MajorProject.uid == member.uid)]

data['major_projects_count'] = len(data['major_projects'])

Expand Down