Minor refactor of the sign() logic

Author: JoelEager

packet/routes/api.py

@@ -15,28 +15,26 @@ def sign(packet_id, info):
             # Check if the CSHer is an upperclassman and if so, sign that row
             for sig in filter(lambda sig: sig.member == info["uid"], packet.upper_signatures):
                 sig.signed = True
-                db.session.commit()
                 app.logger.info("Member {} signed packet {} as an upperclassman".format(info["uid"], packet_id))
-                if not was_100 and packet.is_100():
-                    notify_slack(packet.freshman.name)
-                return "Success: Signed Packet: " + packet.freshman_username
+                return commit_sig(packet, was_100)
 
             # The CSHer is a misc so add a new row
             db.session.add(MiscSignature(packet=packet, member=info["uid"]))
-            db.session.commit()
             app.logger.info("Member {} signed packet {} as a misc".format(info["uid"], packet_id))
-            if not was_100 and packet.is_100():
-                notify_slack(packet.freshman.name)
-            return "Success: Signed Packet: " + packet.freshman_username
+            return commit_sig(packet, was_100)
         else:
             # Check if the freshman is onfloor and if so, sign that row
             for sig in filter(lambda sig: sig.freshman_username == info["uid"], packet.fresh_signatures):
                 sig.signed = True
-                db.session.commit()
                 app.logger.info("Freshman {} signed packet {}".format(info["uid"], packet_id))
-                if not was_100 and packet.is_100():
-                    notify_slack(packet.freshman.name)
-                return "Success: Signed Packet: " + packet.freshman_username
+                return commit_sig(packet, was_100)
 
     app.logger.warn("Failed to add {}'s signature to packet {}".format(info["uid"], packet_id))
     return "Error: Signature not valid.  Reason: Unknown"
+
+def commit_sig(packet, was_100):
+    db.session.commit()
+    if not was_100 and packet.is_100():
+        notify_slack(packet.freshman.name)
+
+    return "Success: Signed Packet: " + packet.freshman_username