Added links for different events #17
Open
+727
−538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabbate19
requested changes
Sep 2, 2025
There was a problem hiding this comment.
Hey @BigSpaceships ! Tysm for making these changes! Happy to see someone take on this service.
Overall looks good! Made some comments around some small typing asks.
Also, can you provide screenshots or video of the UI on desktop and mobile to demonstrate the changes and confirm it works on both?
|
Here's the UI on pc Phone with wider screen and phone with narrow screen Thanks for all the help! |
|
I did notice that you can get a random json response if you go to a deleted event so Ima fix that too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added links for when you're going between open events or events in the history page (makes the back button work and fixes #15)
Also added share link button to event details which copies permalink to the event