Skip to content

Fixes AND-153#269

Merged
zaiatsartem merged 2 commits intomainfrom
AND-153_show_default_token_icon
Apr 14, 2025
Merged

Fixes AND-153#269
zaiatsartem merged 2 commits intomainfrom
AND-153_show_default_token_icon

Conversation

@zaiatsartem
Copy link
Copy Markdown
Contributor

Purpose

Update token placeholder

Changes

  • When a logo fails to load the default icon is shown instead of an infinite loading spinner

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@zaiatsartem zaiatsartem requested a review from Radiokot April 14, 2025 11:47
Copy link
Copy Markdown
Contributor

@Radiokot Radiokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to show the default icon only if the token icon fails to load, not to completely replace the loader. Keep the loader, only use the new icon for .error()

@zaiatsartem zaiatsartem merged commit b81f8ae into main Apr 14, 2025
3 checks passed
@zaiatsartem zaiatsartem deleted the AND-153_show_default_token_icon branch April 14, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants