Skip to content

Test automation 1.0#270

Merged
Radiokot merged 12 commits intomainfrom
test-automation-1.0
Apr 16, 2025
Merged

Test automation 1.0#270
Radiokot merged 12 commits intomainfrom
test-automation-1.0

Conversation

@naumanashaikh
Copy link
Copy Markdown
Contributor

@naumanashaikh naumanashaikh commented Apr 14, 2025

No description provided.

@naumanashaikh naumanashaikh requested a review from Radiokot April 14, 2025 13:01
Copy link
Copy Markdown
Contributor

@Radiokot Radiokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In CustomTestListener, it saves a screenshot for a failed test to screenshots folder in the repository. Why? Shouldn't it be uploaded somewhere instead?
  2. There are multiple C:\Users\nas\Desktop\... paths in the code, please change them to appropriate relative paths within the repository

@naumanashaikh
Copy link
Copy Markdown
Contributor Author

  1. In CustomTestListener, it saves a screenshot for a failed test to screenshots folder in the repository. Why? Shouldn't it be uploaded somewhere instead?
    NS: For now i have comment it out, however it was not taking any screenshot before, we have migrated from localExecution so it has some redundant code. I have created a task for it to remove it permanently.
  1. There are multiple C:\Users\nas\Desktop\... paths in the code, please change them to appropriate relative paths within the repository
    NS: we have migrated from localExecution so it has some redundant code. I have created a task for it to remove it permanently.

@Radiokot Radiokot merged commit 153b529 into main Apr 16, 2025
0 of 2 checks passed
@Radiokot Radiokot deleted the test-automation-1.0 branch April 16, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants