fix(markdown): correctly render nested inline elements #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of the Markdown renderer processed inline elements sequentially without recursion. This caused issues with nested elements, such as a link inside a bold tag, where the inner element was treated as plain text. This commit refactors the inline parsing mechanism to be recursive: - The `InlineElementRule` interface is updated to provide the `InlineElementTokenizer` to each rule. - Container rules (Strong, Italic, Strikethrough) now re-invoke the tokenizer on their content, allowing for nested elements to be parsed correctly. - A test case has been added to `IssuesTest.java` to verify the fix for `**[link](url)**` and prevent regressions. - All inline element rules and their corresponding tests have been updated to reflect the new architecture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of the Markdown renderer processed inline elements sequentially without recursion. This caused issues with nested elements, such as a link inside a bold tag, where the inner element was treated as plain text.
This commit refactors the inline parsing mechanism to be recursive:
InlineElementRuleinterface is updated to provide theInlineElementTokenizerto each rule.IssuesTest.javato verify the fix for**[link](url)**and prevent regressions.