-
Notifications
You must be signed in to change notification settings - Fork 0
New stats page demo #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Conductor-Codes review |
| <img | ||
| src="/images/meta-gradient.png" | ||
| style={{height: '3px', width: '50%'}} | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <img | |
| src="/images/meta-gradient.png" | |
| style={{height: '3px', width: '50%'}} | |
| /> | |
| <img | |
| src="/images/meta-gradient.png" | |
| alt="" | |
| style={{height: '3px', width: '50%'}} | |
| /> |
The image at the bottom of the component lacks an alt attribute. This violates WCAG 1.1.1 (Non-text Content) as screen readers cannot convey the purpose or content of the image to users who are visually impaired. Even decorative images should have alt="" to explicitly indicate they are not meaningful.
Review by Conductor
Is this review helpful? React 👍 or 👎 to let us know!
| <button | ||
| onClick={() => { | ||
| setSelectedDifficulty('all'); | ||
| setSelectedSortMethod('views'); | ||
| }} | ||
| style={{ | ||
| padding: '8px 16px', | ||
| backgroundColor: '#0969da', | ||
| color: 'white', | ||
| border: 'none', | ||
| borderRadius: '6px', | ||
| cursor: 'pointer', | ||
| }}> | ||
| <span className="icon">↺</span> | ||
| </button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <button | |
| onClick={() => { | |
| setSelectedDifficulty('all'); | |
| setSelectedSortMethod('views'); | |
| }} | |
| style={{ | |
| padding: '8px 16px', | |
| backgroundColor: '#0969da', | |
| color: 'white', | |
| border: 'none', | |
| borderRadius: '6px', | |
| cursor: 'pointer', | |
| }}> | |
| <span className="icon">↺</span> | |
| </button> | |
| <button | |
| aria-label="Reset filters" | |
| onClick={() => { | |
| setSelectedDifficulty('all'); | |
| setSelectedSortMethod('views'); | |
| }} | |
| style={{ | |
| padding: '8px 16px', | |
| backgroundColor: '#0969da', | |
| color: 'white', | |
| border: 'none', | |
| borderRadius: '6px', | |
| cursor: 'pointer', | |
| }}> | |
| <span className="icon">↺</span> | |
| </button> |
The reset button only contains an icon (↺) without an accessible name. This violates WCAG 1.1.1 (Non-text Content) as screen reader users won't know the purpose of this button. Icons used as interactive elements must have a text alternative either through visible text, aria-label, or aria-labelledby attributes.
Review by Conductor
Is this review helpful? React 👍 or 👎 to let us know!
Co-authored-by: conductor-codes[bot] <207893014+conductor-codes[bot]@users.noreply.github.com>
Co-authored-by: conductor-codes[bot] <207893014+conductor-codes[bot]@users.noreply.github.com>
Co-authored-by: conductor-codes[bot] <207893014+conductor-codes[bot]@users.noreply.github.com>
Co-authored-by: conductor-codes[bot] <207893014+conductor-codes[bot]@users.noreply.github.com>
|
Test |
No description provided.