Skip to content

Conversation

@87fmartin
Copy link

No description provided.

@smeriwether smeriwether closed this May 5, 2025
@smeriwether smeriwether reopened this May 5, 2025
@smeriwether smeriwether closed this May 5, 2025
@smeriwether smeriwether reopened this May 5, 2025
@Conductor-Codes Conductor-Codes deleted a comment from conductor-codes bot May 7, 2025
@Conductor-Codes Conductor-Codes deleted a comment from conductor-codes bot May 7, 2025
@Conductor-Codes Conductor-Codes deleted a comment from conductor-codes bot May 7, 2025
@Conductor-Codes Conductor-Codes deleted a comment from conductor-codes bot May 7, 2025
@Conductor-Codes Conductor-Codes deleted a comment from conductor-codes bot May 7, 2025
@Conductor-Codes Conductor-Codes deleted a comment from conductor-codes bot May 7, 2025
@Conductor-Codes Conductor-Codes deleted a comment from conductor-codes bot May 7, 2025
@Conductor-Codes Conductor-Codes deleted a comment from conductor-codes bot May 7, 2025
@smeriwether
Copy link
Contributor

@Conductor-Codes review

Comment on lines 564 to 567
<img
src="/images/meta-gradient.png"
style={{height: '3px', width: '50%'}}
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img
src="/images/meta-gradient.png"
style={{height: '3px', width: '50%'}}
/>
<img
src="/images/meta-gradient.png"
alt=""
style={{height: '3px', width: '50%'}}
/>

The image at the bottom of the component lacks an alt attribute. This violates WCAG 1.1.1 (Non-text Content) as screen readers cannot convey the purpose or content of the image to users who are visually impaired. Even decorative images should have alt="" to explicitly indicate they are not meaningful.

Review by Conductor

Is this review helpful? React 👍 or 👎 to let us know!

Comment on lines +281 to +295
<button
onClick={() => {
setSelectedDifficulty('all');
setSelectedSortMethod('views');
}}
style={{
padding: '8px 16px',
backgroundColor: '#0969da',
color: 'white',
border: 'none',
borderRadius: '6px',
cursor: 'pointer',
}}>
<span className="icon">↺</span>
</button>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button
onClick={() => {
setSelectedDifficulty('all');
setSelectedSortMethod('views');
}}
style={{
padding: '8px 16px',
backgroundColor: '#0969da',
color: 'white',
border: 'none',
borderRadius: '6px',
cursor: 'pointer',
}}>
<span className="icon"></span>
</button>
<button
aria-label="Reset filters"
onClick={() => {
setSelectedDifficulty('all');
setSelectedSortMethod('views');
}}
style={{
padding: '8px 16px',
backgroundColor: '#0969da',
color: 'white',
border: 'none',
borderRadius: '6px',
cursor: 'pointer',
}}>
<span className="icon"></span>
</button>

The reset button only contains an icon (↺) without an accessible name. This violates WCAG 1.1.1 (Non-text Content) as screen reader users won't know the purpose of this button. Icons used as interactive elements must have a text alternative either through visible text, aria-label, or aria-labelledby attributes.

Review by Conductor

Is this review helpful? React 👍 or 👎 to let us know!

@Conductor-Codes Conductor-Codes deleted a comment from conductor-codes bot May 8, 2025
smeriwether and others added 4 commits May 8, 2025 08:49
Co-authored-by: conductor-codes[bot] <207893014+conductor-codes[bot]@users.noreply.github.com>
Co-authored-by: conductor-codes[bot] <207893014+conductor-codes[bot]@users.noreply.github.com>
Co-authored-by: conductor-codes[bot] <207893014+conductor-codes[bot]@users.noreply.github.com>
Co-authored-by: conductor-codes[bot] <207893014+conductor-codes[bot]@users.noreply.github.com>
@Conductor-Codes Conductor-Codes deleted a comment from conductor-codes bot May 8, 2025
@RobOBrien
Copy link
Contributor

Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants