-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add Store page with 4 tote products and navigation #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aniatat
wants to merge
4
commits into
main
Choose a base branch
from
feature/store-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bfd6402
feat: Add Store page with 4 tote products and navigation
b2dd395
fix: Resolve hydration error by using simple markdown structure
7a39e5d
feat: Add e-commerce product grid with real tote images
f8b3722
Update src/pages/[[...markdownPath]].js
aniatat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| --- | ||
| title: Store | ||
| --- | ||
|
|
||
| <Intro> | ||
|
|
||
| Welcome to the React Store! Browse our collection of high-quality tote bags perfect for React developers and enthusiasts. | ||
|
|
||
| </Intro> | ||
|
|
||
| ## Our Products {/*our-products*/} | ||
|
|
||
| ### Black Tote {/*black-tote*/} | ||
|
|
||
| **$10 USD** | ||
|
|
||
| A sleek and professional black tote bag perfect for carrying your laptop, books, and React swag. Made with durable materials for everyday use. | ||
|
|
||
| *Product Image Placeholder: 🛍️* | ||
|
|
||
| **[Add to Bag]** | ||
|
|
||
| --- | ||
|
|
||
| ### Pink Tote {/*pink-tote*/} | ||
|
|
||
| **$10 USD** | ||
|
|
||
| A vibrant pink tote bag that stands out in any crowd. Perfect for React enthusiasts who want to show their style while carrying their essentials. | ||
|
|
||
| *Product Image Placeholder: 🛍️* | ||
|
|
||
| **[Add to Bag]** | ||
|
|
||
| --- | ||
|
|
||
| ### White Tote {/*white-tote*/} | ||
|
|
||
| **$10 USD** | ||
|
|
||
| A clean and minimalist white tote bag that goes with everything. Ideal for developers who prefer a classic, understated look. | ||
|
|
||
| *Product Image Placeholder: 🛍️* | ||
|
|
||
| **[Add to Bag]** | ||
|
|
||
| --- | ||
|
|
||
| ### Green Tote {/*green-tote*/} | ||
|
|
||
| **$10 USD** | ||
|
|
||
| An eco-friendly green tote bag that represents growth and sustainability. Perfect for environmentally conscious React developers. | ||
|
|
||
| *Product Image Placeholder: 🛍️* | ||
|
|
||
| **[Add to Bag]** | ||
|
|
||
| --- | ||
|
|
||
| *All tote bags are made with high-quality materials and feature the React logo. Perfect for conferences, meetups, or everyday use!* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "title": "Store", | ||
| "path": "/store", | ||
| "routes": [ | ||
| { | ||
| "hasSectionHeader": true, | ||
| "sectionHeader": "REACT MERCHANDISE" | ||
| }, | ||
| { | ||
| "title": "Store", | ||
| "path": "/store", | ||
| "skipBreadcrumb": true, | ||
| "routes": [ | ||
| { | ||
| "title": "All Products", | ||
| "path": "/store" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All sidebar JSON files are imported statically at the top of the file, including the newly added sidebarStore.json. This means all sidebar data is included in the initial bundle regardless of which section the user is viewing. This increases the initial JavaScript payload size unnecessarily, potentially impacting Core Web Vitals metrics like LCP, FID, and TTI.
Review by Conductor
Is this review helpful? React 👍 or 👎 to let us know!