[BB-891] Fix provisioning for groups and vaults, update documentation #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateovespConductor
force-pushed
the
mateovesp/fix-provisioning
branch
9 times, most recently
from
d0e5fe6 to
2fa7d62
Compare
mateovespConductor
force-pushed
the
mateovesp/fix-provisioning
branch
from
2fa7d62 to
0449f52
Compare
mateovespConductor
requested review from
FeliLucero1,
JavierCarnelli-ConductorOne,
agustin-conductor,
btipling,
luisina-santos,
mateoHernandez123 and
sergiocorral-conductorone
aldevv
reviewed
Jun 19, 2025
aldevv
approved these changes
Jun 19, 2025
luisina-santos
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connector previously failed to provision groups and vaults correctly.
Groups: The issue was caused by using an attribute from the entitlement that returned an empty value. This was resolved by introducing a helper function that extracts the entitlement name from its own ID.
Vaults: When provisioning vaults, the connector failed to include required dependent permissions, which caused 1Password to return errors. This was fixed by implementing a recursive function that correctly traverses and includes all dependent permissions.
In addition, an important limitation regarding service accounts was added to the documentation:
When using a service account to run the connector, vault provisioning is limited by 1Password. Specifically, only vaults that were created by the same service account can be modified. Vaults created by other users or service accounts cannot have permissions granted or revoked using a service account.