Skip to content

[BB-1013] fix pagination for scope #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurenleach merged 2 commits into from
Nov 22, 2025
Merged

[BB-1013] fix pagination for scope #33

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8817b69
fix pagination for scope
MarcusGoldschmidt Nov 3, 2025
d7d168c
fix wrong scope id
aldevv Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/connector/roles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ func (o *roleBuilder) Grants(
grants = append(grants, nextGrant)
}

bag.Pop()
Copy link

@Bencheng21 Bencheng21 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

nextToken, err := bag.NextToken(client.GetNextToken(page, limit, total))
		if err != nil {
			return nil, "", nil, err
		}

I saw this one. Do we need to get the next page from the o.client.GetRolePermissions

Copy link

@laurenleach laurenleach Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://auth0.com/docs/api/management/v2/roles/get-role-permission doesn't say it supports pagination like the other endpoint

nextToken, err := bag.Marshal()
if err != nil {
return nil, "", nil, err
Expand Down
Loading