Conversation
aldevv
requested review from
ggreer and
shackra
and removed request for
shackra
ggreer
reviewed
Apr 16, 2025
| SyncSecrets = field.BoolField( | ||
| "sync-secrets", | ||
| field.WithDescription("Whether to sync secrets or not"), | ||
| ) |
Contributor
There was a problem hiding this comment.
It'd be nice if the CI tests synced secrets. Also do we need extra IAM permissions to read secrets? If so, we should add those to the readme.
Contributor
Author
There was a problem hiding this comment.
added test case, readme already has the needed permissions
Contributor
There was a problem hiding this comment.
Add BATON_SYNC_SECRETS: true to the envs in .github/workflows/ci.yaml
ggreer
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.