Generate grant expansion entitlement IDs without using resource cache. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error with Azure Databricks and improves performance.
btipling
approved these changes
Feb 19, 2025
Contributor
btipling
left a comment
btipling
left a comment
There was a problem hiding this comment.
What was the bug? I can't tell from the diff
Contributor
Author
|
The cache wasn't always fully populated, and we'd fail to fetch the group because we're generating the wrong workspace URL for Azure Databricks instances: https://learn.microsoft.com/en-us/azure/databricks/workspace/workspace-details But we don't need to fetch the group to figure out the entitlement ID to add the grant expansion annotation. We just need to know the group ID and the parent resource ID (since groups can belong to accounts or workspaces). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error with Azure Databricks and improves performance.