Conversation
mbburch
force-pushed
the
mbburch/update-sdk-v0_3_10
branch
from
bee0517 to
f9c14b5
Compare
mbburch
force-pushed
the
mbburch/update-sdk-v0_3_10
branch
from
f9c14b5 to
1f0cc5b
Compare
laurenleach
reviewed
Jun 2, 2025
laurenleach
reviewed
Jun 2, 2025
laurenleach
reviewed
Jun 2, 2025
laurenleach
reviewed
Jun 3, 2025
| field.WithDisplayName("User ID"), | ||
| field.WithDescription("The Expensify partner user id used to connect to the Expensify API."), | ||
| field.WithRequired(true), | ||
| field.WithIsSecret(true), |
Contributor
There was a problem hiding this comment.
I'm not sure why this is secret in c1, I don't think it should be, but we can change it in a follow up
laurenleach
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update baton-sdk in prep for containerization.