Skip to content

[INC-300] baton-github: include the error in the returned message #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bencheng21 merged 6 commits into from
Jul 24, 2025
Merged

[INC-300] baton-github: include the error in the returned message #98

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca19315
[INC-300] baton-github: include the error in the returned message
Bencheng21 Jul 24, 2025
b9eed40
now
Bencheng21 Jul 24, 2025
cdc712e
add isRatelimited to All list methods
Bencheng21 Jul 24, 2025
4239b2b
more
Bencheng21 Jul 24, 2025
0eaff5b
address comments
Bencheng21 Jul 24, 2025
2c8e33f
cursor
Bencheng21 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/connector/connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,15 @@ func (gh *GitHub) Validate(ctx context.Context) (annotations.Annotations, error)
membership, _, err := gh.client.Organizations.GetOrgMembership(ctx, "", o)
if err != nil {
if filterOrgs {
return nil, fmt.Errorf("access token must be an admin on the %s organization", o)
return nil, fmt.Errorf("access token must be an admin on the %s organization: %w", o, err)
}
continue
}

// Only sync orgs that we are an admin for
if strings.ToLower(membership.GetRole()) != orgRoleAdmin {
if filterOrgs {
return nil, fmt.Errorf("access token must be an admin on the %s organization", o)
return nil, fmt.Errorf("access token must be an admin on the %s organization: %w", o, err)
}
continue
}
Expand Down
Loading