Skip to content

Upgrade baton-sdk to v0.3.24.#120

Merged
ggreer merged 1 commit intomainfrom
ggreer/upgrade-baton-sdk
Jul 31, 2025
Merged

Upgrade baton-sdk to v0.3.24.#120
ggreer merged 1 commit intomainfrom
ggreer/upgrade-baton-sdk

Conversation

@ggreer
Copy link
Contributor

@ggreer ggreer commented Jul 31, 2025

Dependabot couldn't upgrade this because it required a change to the config.

Summary by CodeRabbit

  • New Features

    • Updated configuration to display the connector name as "LDAP" in relevant interfaces.
  • Chores

    • Upgraded dependencies for improved stability and support.

@coderabbitai
Copy link

coderabbitai bot commented Jul 31, 2025

Walkthrough

The changes update the go.mod file to bump the baton-sdk dependency and add a new indirect dependency. In pkg/config/config.go, the initialization of the Configuration variable is refactored to use explicit option functions, adding a connector display name and refactoring how constraints are applied.

Changes

Cohort / File(s) Change Summary
Dependency Updates
go.mod
Updated baton-sdk dependency from v0.3.9 to v0.3.24; added indirect dependency on golang.org/x/term v0.30.0
Configuration Refactor
pkg/config/config.go
Refactored Configuration initialization to use option functions, adding connector display name and explicit constraints

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant field
    App->>field: NewConfiguration(ConfigurationFields, WithConnectorDisplayName("LDAP"), WithConstraints(ConfigRelations...))
    field-->>App: Configuration object with display name and constraints set
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Suggested labels

dependencies

Suggested reviewers

  • pquerna

Poem

A rabbit hops through fields of code,
Dependencies light, the path is showed.
LDAP’s name now shines so bright,
Constraints are bundled, just so right.
With every hop, a version new—
The garden’s fresh, reviewed by you!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8bf418f and 945d021.

⛔ Files ignored due to path filters (59)
  • go.sum is excluded by !**/*.sum and included by none
  • vendor/github.com/conductorone/baton-sdk/pb/c1/config/v1/config.pb.go is excluded by !**/*.pb.go, !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pb/c1/config/v1/config.pb.validate.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pb/c1/connector/v2/annotation_external_ticket.pb.go is excluded by !**/*.pb.go, !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pb/c1/connector/v2/annotation_external_ticket.pb.validate.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pb/c1/connector/v2/resource.pb.go is excluded by !**/*.pb.go, !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pb/c1/connector/v2/resource.pb.validate.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/cli/commands.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/cli/lambda_server__added.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/config/config.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/connectorbuilder/connectorbuilder.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/crypto/password.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/field/defaults.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/field/field_options.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/field/marshal.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/field/struct.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/lambda/grpc/client.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/ratelimit/http.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/sdk/version.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/sync/syncer.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/types/resource/role_trait.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/uhttp/transport.go is excluded by !vendor/** and included by none
  • vendor/github.com/conductorone/baton-sdk/pkg/uhttp/wrapper.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/asm.s is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/asm_plan9_386.s is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/asm_plan9_amd64.s is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/asm_plan9_arm.s is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/const_plan9.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/dir_plan9.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/env_plan9.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/errors_plan9.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/mkall.sh is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/mkerrors.sh is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/mksysnum_plan9.sh is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/pwd_go15_plan9.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/pwd_plan9.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/race.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/race0.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/str.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/syscall.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/syscall_plan9.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/zsyscall_plan9_386.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/zsyscall_plan9_amd64.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/zsyscall_plan9_arm.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/sys/plan9/zsysnum_plan9.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/CONTRIBUTING.md is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/LICENSE is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/PATENTS is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/README.md is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/codereview.cfg is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/term.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/term_plan9.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/term_unix.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/term_unix_bsd.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/term_unix_other.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/term_unsupported.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/term_windows.go is excluded by !vendor/** and included by none
  • vendor/golang.org/x/term/terminal.go is excluded by !vendor/** and included by none
  • vendor/modules.txt is excluded by !vendor/** and included by none
📒 Files selected for processing (2)
  • go.mod (2 hunks)
  • pkg/config/config.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test
🔇 Additional comments (3)
go.mod (2)

79-79: LGTM! New indirect dependency aligns with SDK upgrade.

The addition of golang.org/x/term v0.30.0 as an indirect dependency is expected and likely introduced by the updated baton-sdk version.


8-8: SDK Upgrade Verified: No Breaking Changes from v0.3.9 → v0.3.24

I reviewed the changelogs for v0.3.10 through v0.3.24—each release adds new features or logging enhancements without deprecations or removed APIs. The updates in pkg/config/config.go remain fully compatible. The go.mod bump to baton-sdk v0.3.24 can be approved.

pkg/config/config.go (1)

65-68: LGTM! Modernized configuration API usage.

The refactoring to use functional options (field.WithConnectorDisplayName and field.WithConstraints) aligns with the updated baton-sdk and provides better API design. The explicit connector display name "LDAP" improves clarity, and the constraints are now properly structured as options rather than variadic arguments.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ggreer/upgrade-baton-sdk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ggreer ggreer force-pushed the ggreer/upgrade-baton-sdk branch from bad92b9 to 945d021 Compare July 31, 2025 00:41
@ggreer ggreer merged commit 2c7c8c6 into main Jul 31, 2025
5 checks passed
@ggreer ggreer deleted the ggreer/upgrade-baton-sdk branch July 31, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant