-
Notifications
You must be signed in to change notification settings - Fork 0
[BB-1822] - Containerize Connector - MongoDB #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughGo toolchain and multiple module dependencies updated; GetString in generated config now accepts both string and []byte; several config fields' defaults changed and connector display name updated. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
@mateoHernandez123 @btipling we tried to containerize this previously. It did not work for the database stuff, it needs sock5, chris did some work to support this but I think we need to update the connector to use this the behavior it had when we containerized: syncing successfully but dropping any database resources |
I just updated the SDK version in this same PR. Can you confirm if it works? @laurenleach |
b3e2ab1 to
330b619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pkg/config/config.go (1)
22-47: Defaults now enable invite creation and DB sync—confirm this breaking change is intended.Previously omitted flags would default to false; now they default to true, which can create users/invites and sync databases unexpectedly. If this is intended, please add a migration note and update docs; if not, consider reverting.
💡 Possible rollback to preserve prior defaults
var CreateInviteKeyField = field.BoolField( "create-invite-key", field.WithDisplayName("Create Invite"), field.WithDescription("If enabled, Baton will create invites for users that do not have an account in MongoDB Atlas when provisioning."), - field.WithDefaultValue(true), + field.WithRequired(false), ) ... var EnableSyncDatabases = field.BoolField( "enable-sync-databases", field.WithDisplayName("Sync Databases"), field.WithDescription("If enabled, Baton will sync database users and roles."), - field.WithDefaultValue(true), + field.WithRequired(false), )
🧹 Nitpick comments (1)
pkg/config/conf.gen.go (1)
44-55: Add a small test for the new []byte path.This locks in the new behavior and prevents regressions in config loading.
Pull Request
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the Connector in any way?
Useful links:
Issue Linking
What's new?
Summary by CodeRabbit
Chores
Improvements
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.