Skip to content

test: verify regression workflow fix #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gontzess wants to merge 1 commit into from
Closed

test: verify regression workflow fix #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/verify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
verify:
uses: ConductorOne/github-workflows/.github/workflows/verify.yaml@v4
uses: ConductorOne/github-workflows/.github/workflows/verify.yaml@gontzess/move-regression-workflow-local
Copy link

@coderabbitai coderabbitai bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n .github/workflows/verify.yaml

Repository: ConductorOne/baton-mysql

Length of output: 1874

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Verify reusable workflow refs are immutable SHAs in repo workflows.
fd -t f '.*\.ya?ml$' .github/workflows | while read -r file; do
  rg -nP '^\s*uses:\s*ConductorOne/github-workflows/\.github/workflows/[^@]+@([^\s#]+)' "$file" \
  | while IFS=: read -r path line content; do
      ref="$(printf '%s' "$content" | sed -E 's/.*@([^[:space:]]+).*/\1/')"
      if [[ ! "$ref" =~ ^[0-9a-fA-F]{40}$ ]]; then
        echo "$path:Line $line uses non-immutable ref: $ref"
      fi
    done
done

Repository: ConductorOne/baton-mysql

Length of output: 1874

Pin the reusable workflow to an immutable ref before any merge.

Line 13 uses a branch ref (@gontzess/move-regression-workflow-local), which is mutable. If this PR is merged by mistake, the verify workflow becomes non-deterministic and weakens CI supply-chain guarantees.

Suggested change 
-    uses: ConductorOne/github-workflows/.github/workflows/verify.yaml@gontzess/move-regression-workflow-local
+    uses: ConductorOne/github-workflows/.github/workflows/verify.yaml@<commit-sha>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/verify.yaml at line 13, The reusable workflow reference
currently uses a mutable branch ref ("uses:
ConductorOne/github-workflows/.github/workflows/verify.yaml@gontzess/move-regression-workflow-local");
update it to an immutable ref (a commit SHA or a signed/tagged release) by
replacing the branch name with the corresponding commit SHA or a release tag so
the workflow is pinned to a fixed, auditable revision before merging.

with:
ref: ${{ github.event.pull_request.head.sha || github.sha }}
connector: baton-mysql
Expand Down
Loading