[DUCT-10035] Allow connector to use email field from account provisioning schema

[VVill-ga]

https://conductorone.atlassian.net/browse/DUCT-10035

Currently, account provisioning just uses the requestor's main email and does not respect the CEL expression in the account provisioning schema. If that field is available and has been evaluated to a non-empty string, we should use that instead.

Summary by CodeRabbit

• New Features
  • Improved account creation by prioritizing a user’s profile email (when provided) over the default login value, ensuring more accurate communication details.

[coderabbitai]

Walkthrough

The change refines the CreateAccount method in the roleSyncer struct by adjusting how the email is selected during user account creation. Instead of always defaulting to the login value obtained via accountInfo.GetLogin(), the method now checks if a profile exists and if it contains a non-empty "email" field. When such a field is found, its value is used to create the user account; otherwise, the login value is retained.

Changes

File(s)	Change Summary
pkg/connector/role.go	Updated the CreateAccount method in roleSyncer to check for a non-empty "email" in accountInfo.Profile and use it if available, otherwise fallback to the original login.

Sequence Diagram(s)

sequenceDiagram
    participant RS as roleSyncer
    participant AI as accountInfo
    participant Pr as Profile (optional)
    participant Cl as client

    RS->>AI: Get login via GetLogin()
    alt Profile exists?
        AI-->>RS: Return Profile
        RS->>Pr: Retrieve "email" field
        alt "email" key exists & non-empty?
            Pr-->>RS: Return email value
            RS->>Cl: CreateUser(email from profile)
        else
            RS->>Cl: CreateUser(login value)
        end
    else
        AI-->>RS: No Profile
        RS->>Cl: CreateUser(login value)
    end

Loading

Poem

Hi there, I'm a little bunny, hopping through the code,
Found an email path so sunny, on a brand new road.
From login to profile I did peek,
To find an address unique and sleek.
CodeRabbit cheers, with whiskers aloft,
For changes that lift our code so soft.
🐇💻 Hop along on trails so bright!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 823dea7 and 7052ac8.

📒 Files selected for processing (1)

• pkg/connector/role.go (1 hunks)

🔇 Additional comments (1)

pkg/connector/role.go (1)

370-379: Good implementation of the email field preference

The changes correctly implement the requirement to use the email field from the account provisioning schema when available. The code properly:

1. Defaults to using the login value as the email
2. Checks if the profile contains an "email" field with a non-empty value
3. Uses the profile email value when available, maintaining backward compatibility

This enhancement improves flexibility by respecting the Custom Expression Language (CEL) expression defined in the account provisioning schema, which aligns well with the PR objectives.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.