Skip to content

Conversation

@mj-palanker
Copy link
Contributor

@mj-palanker mj-palanker commented Mar 17, 2025

update to newest sdk and start being just a "Resource Deleter" for Accounts

    {
      "resourceType":  {
        "id":  "role",
        "displayName":  "Role",
        "traits":  [
          "TRAIT_ROLE",
          "TRAIT_USER"
        ]
      },
      "capabilities":  [
        "CAPABILITY_SYNC",
        "CAPABILITY_PROVISION",
        "CAPABILITY_ACCOUNT_PROVISIONING",
        "CAPABILITY_CREDENTIAL_ROTATION",
        "CAPABILITY_RESOURCE_DELETE"
      ]
    },

Summary by CodeRabbit

  • Chores
    • Upgraded the core runtime and toolchain to leverage the latest performance and security improvements.
    • Updated multiple external dependencies to enhance overall system stability and compatibility.
    • Introduced aliasing for the pgx package in various files for improved readability.
    • Removed the role creation functionality from the role management system.

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2025

Walkthrough

The pull request updates the go.mod file to reflect changes in the Go version and various dependencies. The Go version has been upgraded from 1.22.10 to 1.23.4, and the toolchain version has been updated from go1.23.4 to go1.24.1. Several AWS SDK dependencies have been modified, and new dependencies have been added, including github.com/aws/aws-lambda-go. Additionally, the import statements for the pgx package in multiple files have been updated to use an alias, enhancing readability without altering functionality.

Changes

File Change Summary
go.mod - Updated Go version from 1.22.10 to 1.23.4 and toolchain from go1.23.4 to go1.24.1.
- Upgraded github.com/conductorone/baton-sdk from v0.2.65 to v0.2.84.
- Updated AWS SDK dependencies (e.g., aws-sdk-go-v2 from v1.32.4 to v1.36.3 with related submodules) and added github.com/aws/aws-lambda-go v1.47.0.
- Incremented versions for other libraries including go-jose (v3 to v4), protoc-gen-validate, and others.
- Added several indirect dependencies while removing older versions of some libraries.
pkg/postgres/databases.go - Updated import statement for pgx from import "github.com/jackc/pgx/v4" to import pgx "github.com/jackc/pgx/v4".
pkg/postgres/logger.go - Updated import statement for pgx from import "github.com/jackc/pgx/v4" to import pgx "github.com/jackc/pgx/v4".
pkg/postgres/roles.go - Updated import statement for pgx from import "github.com/jackc/pgx/v4" to import pgx "github.com/jackc/pgx/v4".
pkg/connector/role.go - Removed Create method from roleSyncer struct.

Possibly related PRs

  • Update baton-sdk to v0.2.51 #24: The changes involve updating the github.com/conductorone/baton-sdk dependency to a newer version, while this PR updates the same dependency to an earlier version, indicating a direct relationship in terms of dependency management.
  • Update baton sdk and regenerate capabiltiies #21: This PR is related through the github.com/conductorone/baton-sdk dependency, as both involve updates to this package, albeit with different version changes.

Suggested reviewers

  • ggreer
  • phoebesimon

Poem

I'm a nimble rabbit, leaping with delight,
Upgrading our modules from morning till night.
Go versions now shine in a fresher display,
Dependencies updated in a magical way.
With each new version, my heart hops along—
Celebrating change with a joyful song!
🐰🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 993897a and 14749f5.

📒 Files selected for processing (1)
  • pkg/connector/role.go (0 hunks)
💤 Files with no reviewable changes (1)
  • pkg/connector/role.go

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ggreer ggreer merged commit 6556676 into main Apr 3, 2025
2 of 3 checks passed
@ggreer ggreer deleted the mjp/sdk-update branch April 3, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants