Provisioning for page #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shackra
reviewed
Feb 13, 2025
pkg/client/group.go
Outdated
Comment on lines
111
to
158
| _, _ = sb.WriteString(`select "id", "accessLevel" from group_folder_defaults WHERE "groupId"=$1 AND "folderId"=$2`) | ||
| _, _ = sb.WriteString(``) |
There was a problem hiding this comment.
should that remain without a SQL statement tho?
Contributor
Author
There was a problem hiding this comment.
It was not supposed to be empty, I fix it.
Comment on lines
-13
to
+12
| return fmt.Sprintf("%s:%d", resourceTypeID, id) | ||
| return fmt.Sprintf("%c%d", resourceTypeID[0], id) |
There was a problem hiding this comment.
%c will print the character "represented by the corresponding Unicode code point", are you sure this is what you want?
btipling
reviewed
Feb 14, 2025
| } | ||
| } | ||
|
|
||
| func findPageGroupPermission(ctx context.Context, client *client.Client, pageId int64, permission string, userId int64) error { |
btipling
reviewed
Feb 14, 2025
| return &ret, nil | ||
| } | ||
|
|
||
| func (c *Client) CreateGroup(ctx context.Context, organizationID *int64, name string) error { |
Contributor
There was a problem hiding this comment.
I think they'll need to update the permissions they give our connectors. I will let CS know
btipling
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retool does not provide Provisioning Page ot user
Retool provides Groups access pages, user has groups
Refactor IDs for groups and pages
Add provisioning for page to group
Add GrantExpandable for page
Add Grant page to user
If the group does not exist, we should create one group then link to the user