Skip to content

Increase max GRPC message size to 10MB.#357

Closed
ggreer wants to merge 1 commit intomainfrom
ggreer/grpc-max-message-size
Closed

Increase max GRPC message size to 10MB.#357
ggreer wants to merge 1 commit intomainfrom
ggreer/grpc-max-message-size

Conversation

@ggreer
Copy link
Contributor

@ggreer ggreer commented Apr 24, 2025

Note: If we're going to increase this limit, it should probably only be for service mode and one shot, not hosted connectors.

Summary by CodeRabbit

  • New Features
    • Increased the maximum allowed message size for sending and receiving data over gRPC connections to 10MB, enabling support for larger payloads on both server and client sides.

@coderabbitai
Copy link

coderabbitai bot commented Apr 24, 2025

Walkthrough

The change introduces a new constant for maximum gRPC message size, increasing it from the default 4MB to 10MB. This constant is applied to both the gRPC server and client configurations within the connector package, updating the maximum allowed sizes for sending and receiving messages. No other logic, error handling, or control flow is altered.

Changes

File(s) Change Summary
internal/connector/connector.go Added maxMsgSize constant (10MB) and updated gRPC server and client options to use this new limit.

Poem

A hop and a leap, the messages grow,
Ten megabytes now, through gRPC they flow.
From server to client, the limit’s increased,
No more message truncation, delivery’s a feast!
With a twitch of my nose and a wiggle of ear,
Big payloads are welcome—let’s give a cheer! 🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 548f986 and b12bcc2.

📒 Files selected for processing (1)
  • internal/connector/connector.go (3 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
internal/connector/connector.go (3)
vendor/google.golang.org/grpc/server.go (2)
  • MaxRecvMsgSize (407-411)
  • MaxSendMsgSize (415-419)
vendor/google.golang.org/grpc/dialoptions.go (1)
  • WithDefaultCallOptions (239-243)
vendor/google.golang.org/grpc/rpc_util.go (2)
  • MaxCallRecvMsgSize (347-349)
  • MaxCallSendMsgSize (371-373)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: go-test (1.23.x, windows-latest)
🔇 Additional comments (3)
internal/connector/connector.go (3)

35-36: Reasonable increase to message size limit.

The introduction of the maxMsgSize constant with a clear comment explaining the change from the default 4MB to 10MB is well-documented. This constant value is appropriately calculated (1024 * 1024 * 10).


162-163: Server-side message size limits correctly implemented.

The server configuration properly applies the new message size limit to both receive and send operations, ensuring the server can handle larger payloads in both directions.


307-310: Client-side message size limits correctly implemented.

The client configuration correctly applies the new message size limit to both receive and send operations through the appropriate gRPC call options. This ensures consistency between server and client size limits.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ggreer ggreer closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant