Skip to content

don't reprocess#699

Closed
pquerna wants to merge 1 commit intomainfrom
pq/dontreprocess
Closed

don't reprocess#699
pquerna wants to merge 1 commit intomainfrom
pq/dontreprocess

Conversation

@pquerna
Copy link
Contributor

@pquerna pquerna commented Feb 21, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced sync operation handling to prevent unnecessary re-execution on subsequent application launches.

@pquerna pquerna changed the title don't recprocess don't reprocess Feb 21, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 21, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

A data-backfill operation is added to mark old syncs as backfilled by setting supports_diff to 1 after completing the existing expansion backfill pass. This prevents the migration from re-running on subsequent opens.

Changes

Cohort / File(s) Summary
Backfill State Update
pkg/dotc1z/grants.go
Adds post-backfill operation to mark old syncs (where supports_diff is 0) as backfilled by updating the column to 1, using syncRuns.Name() to target the correct table.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hops with glee through data rows,
Old syncs marked where migration goes,
No repeat work, just one swift dance,
The backfill blooms with gentle prance!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'don't reprocess' is directly related to the main change: adding logic to prevent re-running the migration on subsequent opens by marking old syncs as backfilled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pq/dontreprocess

Comment @coderabbitai help to get the list of available commands and usage tips.

@kans kans closed this Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants