fix: map deactivated Slack users to STATUS_DISABLED instead of STATUS_DELETED#74
Open
c1-dev-bot[bot] wants to merge 1 commit intomainfrom
Open
fix: map deactivated Slack users to STATUS_DISABLED instead of STATUS_DELETED#74c1-dev-bot[bot] wants to merge 1 commit intomainfrom
c1-dev-bot[bot] wants to merge 1 commit intomainfrom
Conversation
…_DELETED Slack's API sets the `Deleted` field to `true` for deactivated users, not permanently deleted users. The standard API code path was mapping this to STATUS_DELETED, causing ConductorOne to show deactivated Slack users as "Deleted" instead of "Suspended" (the display for STATUS_DISABLED). The SCIM API code path already correctly maps inactive users to STATUS_DISABLED. This change aligns the standard API path with the SCIM path and with Slack's actual semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletedfield totrue. This field indicates deactivation, not permanent deletion.userResource()was mappingDeleted: truetoSTATUS_DELETED, causing ConductorOne to display these users as "Deleted" (red) instead of "Suspended" (yellow).scimUserResource()already correctly maps inactive users (Active: false) toSTATUS_DISABLED.Deleted: truetoSTATUS_DISABLED, which the ConductorOne UI displays as "Suspended" — the correct representation for deactivated Slack users.Test plan
Automated PR Notice
This PR was automatically created by c1-dev-bot as a potential implementation.
This code requires: