Account provisioning support #40
Conversation
examples/wordpress.yml
Outdated
| vars: | ||
| username: "input.username" | ||
| email: "input.email" | ||
| password: "md5(credentials.password)" |
There was a problem hiding this comment.
md5 isn't actually a valid CEL method here, had this as an example.
pkg/bsql/user_syncer.go
Outdated
| Resource: accountResource, | ||
| } | ||
|
|
||
| return car, []*v2.PlaintextData{ptd}, nil, nil |
There was a problem hiding this comment.
If we are performing "no password" we shouldn't return plaintextData here. it can be an empty slice?
https://github.com/ConductorOne/baton-active-directory/blob/c433f970657570145c0e146e3b9ba8e420c21355/pkg/connector/users.go#L118
Here in AD we create an uninitialized var and just return it if we didn't generate it.
There was a problem hiding this comment.
I think I will add something similar and skip everything except no_password option for now
pkg/bsql/user_syncer.go
Outdated
| return nil, nil, nil, err | ||
| } | ||
|
|
||
| plainTextPassword, err := crypto.GeneratePassword(credentialOptions) |
There was a problem hiding this comment.
You might want to assert that the credentialOptions are infact no password
just until we actually implement it.
| func (t *Env) AccountProvisioningInputs(inputs map[string]any) (map[string]any, error) { | ||
| ret := make(map[string]any) | ||
|
|
||
| ret["input"] = inputs | ||
|
|
||
| return ret, nil | ||
| } |
There was a problem hiding this comment.
It's entirely possible that we're missing some functionality here. You can see other functions in this file evaluate some of these inputs as cel expressions. I'm not sure if that's something we want to do here, but this is where we'd do it I think
There was a problem hiding this comment.
I think we can skip this altogether because prepareSchemaVars handles the input
pkg/bsql/sql_syncer.go
Outdated
| if rt.Traits[0] == v2.ResourceType_TRAIT_USER { | ||
| rv = newUserSyncer(rt, rtConfig, db, dbEngine, celEnv, c) | ||
| } else { |
There was a problem hiding this comment.
the "rtConfig" object is a ResourceType and it should have a AccountProvisioning *AccountProvisioning you can check here. that's probably a better thing to do here
Description
Bug fix
New feature
Add account provisioning support with no password configuration.
Useful links: