-
Notifications
You must be signed in to change notification settings - Fork 1
[BB-1686] add push attribute action support and example #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b8ec5f8
add push attribute action support and example
agustin-conductor 880d62f
add missing attr after rebase
agustin-conductor 3dc4ed2
remove unnecessary if statement
agustin-conductor 69c81c1
use any instead of interface{} in normalizeValue func
agustin-conductor e0099a6
add support for queries in actions
agustin-conductor 3d3a96d
add ci test and validation for actionCfg
agustin-conductor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,3 +88,18 @@ jobs: | |
| connector: ./baton-sql | ||
| account-email: [email protected] | ||
| account-login: "robert'); drop table users; --" | ||
| - name: Run update user attributes action test | ||
| run: | | ||
| ./baton-sql --invoke-action=update_user_attributes --invoke-action-args='{ | ||
| "user_id": "jane.doe", | ||
| "attrs": { | ||
| "first_name": "Janet", | ||
| "job_title": "Senior Software Engineer" | ||
| }, | ||
| "attrs_update_mask": ["first_name", "job_title"] | ||
| }' | ||
| - name: Verify update user attributes action | ||
| run: | | ||
| psql -h localhost --user postgres -d batondb -t -c "SELECT attr_first_name, attr_job_title FROM users WHERE username = 'jane.doe'" | grep -q "Janet.*Senior Software Engineer" | ||
| env: | ||
| PGPASSWORD: secretpassword | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably test the update user attr action in the postgres CI test.
It would be nice if we ran the mysql example in CI, similar to how we run the postgres example. But that can be a separate pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added ci test