Add proto metadata options for chunking #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A follow-up to #204 which adds options for the introduced metadata fields, so that the metadata field names are part of the proto definition. Also updates the test that ensures Go constants match the proto constants.
Note that
buf breakingwill complain, because the file option types changed. Those are not meant to represent the type (all types in the metadata are strings anyway), we're just using those options to make sure the metadata constants are defined in the proto file and are accessible through code. Kinda hacky, but hey, there's no other way to do constants in proto files.Quick checks: