Skip to content

Conversation

@lyuboxa
Copy link

@lyuboxa lyuboxa commented Oct 18, 2024

Description

Fixes ConduitIO/conduit-connector-sdk#197

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso mentioned this pull request Oct 22, 2024
4 tasks
@hariso
Copy link
Contributor

hariso commented Oct 22, 2024

@lyuboxa thanks for this:) This fix will land in the SDK: ConduitIO/conduit-connector-sdk#196.

However, your cleanup of the code looks good to me, so I've extracted it here: #218.

@lyuboxa
Copy link
Author

lyuboxa commented Oct 22, 2024

close in favour of #218

@lyuboxa lyuboxa closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Key/payload are not encoded in schema when schema is attached

3 participants