Skip to content

Conversation

@rauanmayemir
Copy link
Contributor

@rauanmayemir rauanmayemir commented May 4, 2025

Description

In the spirit of getting familiar with the code base I added a fix with validation rules for logrepl.slotName config which I myself got bitten by.

Turns out, publications are fine with special characters in the name, but not replication slots.
Oddly, this is the only place where it's documented: https://www.postgresql.org/docs/17/warm-standby.html#STREAMING-REPLICATION-SLOTS-MANIPULATION

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso merged commit d52fadf into ConduitIO:main May 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants