Skip to content

Conversation

@raulb
Copy link
Contributor

@raulb raulb commented May 6, 2025

Description

Leftover from #279. Forgot the snapshot iterator:

  • with records := make([]opencdc.Record, 0, n) => 8332.25 msg/s
  • with var records []opencdc.Record => 148174.05 msg/s

It prepares the connector for a newer release.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb requested a review from a team as a code owner May 6, 2025 13:35
@raulb raulb self-assigned this May 6, 2025
@github-project-automation github-project-automation bot moved this to Triage in Conduit Main May 6, 2025
@raulb raulb moved this from Triage to Ready for review in Conduit Main May 6, 2025
@github-project-automation github-project-automation bot moved this from Ready for review to Reviewed (ready to ship) in Conduit Main May 6, 2025
@raulb raulb merged commit 15caf2e into main May 6, 2025
3 checks passed
@raulb raulb deleted the fix-read-n-slowness-snapshot branch May 6, 2025 13:38
@github-project-automation github-project-automation bot moved this from Reviewed (ready to ship) to Done in Conduit Main May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants