Supporting reading and writing numeric/decimal values without loss of precision #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
force-pushed
the
haris/pg-numeric-to-big-rat
branch
from
b6c5771 to
31939cf
Compare
hariso
changed the title
hariso
changed the title
raulb
reviewed
May 28, 2025
lyuboxa
approved these changes
May 29, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #292.
This PR adds support for reading
numeric/decimalvalues and writing those. The values are read intobig.Ratvalues.big.Ratvalues are also written intonumeric/decimalcolumns in the database.To convert a
big.Ratvalue (which is a fractional number) into a numeric value, we need to calculate the ratio up to a given precision, which is retrieved from the database. The precision/scale from the database is cached and expires after 5 minutes.Quick checks: