Skip to content

Conversation

@hariso
Copy link
Contributor

@hariso hariso commented Jan 31, 2025

Description

A few improvements that came out from ConduitIO/conduit-connector-postgres#232.

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review January 31, 2025 20:00
@hariso hariso requested a review from a team as a code owner January 31, 2025 20:00
@hariso hariso requested a review from lovromazgon February 3, 2025 18:25
@lovromazgon lovromazgon merged commit 60ed5b1 into specgen Feb 4, 2025
3 checks passed
@lovromazgon lovromazgon deleted the haris/specgen-improvements branch February 4, 2025 15:33
lovromazgon added a commit that referenced this pull request Feb 4, 2025
* connector.yaml: validate Git tag and connector version (#60)

* Use connector.yaml for connector specifications (#62)

* Update README.md

Co-authored-by: Maha Hajja <82542081+maha-hajja@users.noreply.github.com>

* Update source.go

Co-authored-by: Maha Hajja <82542081+maha-hajja@users.noreply.github.com>

* re-generate

* Scripts to bump version, tag  (#71)

* specgen and readmegen improvements  (#75)

* specgen and readmegen improvements

* use readmegen in the readme

* use yaml

* fix setup.sh

* make generate

* go mod tidy

* pr feedback

* note about dev

* re-generate

* mention make install-tools

* handle errors in bump_version, use yq

* check if conn-sdk-cli is installed

* Update Makefile

* Update README.md

---------

Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>

* Update README.md

* go mod tidy

---------

Co-authored-by: Maha Hajja <82542081+maha-hajja@users.noreply.github.com>
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants