-
Notifications
You must be signed in to change notification settings - Fork 214
add dump subcommand which can dump all eSpace account as json file #3314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9bcf6d6 to
d600b63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peilun-conflux reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ChenxingLi)
crates/client/src/state_dump.rs line 177 at r1 (raw file):
let address_hash = keccak(address); let code = if is_contract {
Is it possible to have code or storage if is_contract is false? If not, we can add a sanity check here just in case.
bins/conflux/src/command/dump.rs line 71 at r1 (raw file):
fn get_state_dump_config(&self) -> Result<StateDumpConfig, String> { let address_str = self.start.strip_prefix("0x").unwrap_or(&self.start);
We have parse_hex_string for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 15 of 23 files reviewed, 2 unresolved discussions (waiting on @ChenxingLi and @peilun-conflux)
bins/conflux/src/command/dump.rs line 71 at r1 (raw file):
Previously, peilun-conflux wrote…
We have
parse_hex_stringfor this.
Done.
crates/client/src/state_dump.rs line 177 at r1 (raw file):
Previously, peilun-conflux wrote…
Is it possible to have
codeorstorageifis_contractisfalse? If not, we can add a sanity check here just in case.
Add log for this case
e6e0386 to
d8ab4e2
Compare
add log add read_all_with_callback split state dump into multiple task add more log to indicate progress
d8ab4e2 to
5118c30
Compare
add logic to filter core space storage keys
5f9f1a3 to
51915df
Compare
This change is