Skip to content

Conversation

@Pana
Copy link
Member

@Pana Pana commented Aug 22, 2025

This change is Reviewable

@Pana Pana force-pushed the feat/stateDump1 branch 4 times, most recently from 9bcf6d6 to d600b63 Compare August 25, 2025 06:10
@Pana Pana force-pushed the feat/stateDump1 branch from d600b63 to 8bd7386 Compare August 26, 2025 01:46
Copy link
Contributor

@peilun-conflux peilun-conflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peilun-conflux reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ChenxingLi)


crates/client/src/state_dump.rs line 177 at r1 (raw file):

        let address_hash = keccak(address);

        let code = if is_contract {

Is it possible to have code or storage if is_contract is false? If not, we can add a sanity check here just in case.


bins/conflux/src/command/dump.rs line 71 at r1 (raw file):

    fn get_state_dump_config(&self) -> Result<StateDumpConfig, String> {
        let address_str = self.start.strip_prefix("0x").unwrap_or(&self.start);

We have parse_hex_string for this.

Copy link
Member Author

@Pana Pana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 15 of 23 files reviewed, 2 unresolved discussions (waiting on @ChenxingLi and @peilun-conflux)


bins/conflux/src/command/dump.rs line 71 at r1 (raw file):

Previously, peilun-conflux wrote…

We have parse_hex_string for this.

Done.


crates/client/src/state_dump.rs line 177 at r1 (raw file):

Previously, peilun-conflux wrote…

Is it possible to have code or storage if is_contract is false? If not, we can add a sanity check here just in case.

Add log for this case

@Pana Pana force-pushed the feat/stateDump1 branch 2 times, most recently from e6e0386 to d8ab4e2 Compare August 29, 2025 10:25
add log

add read_all_with_callback

split state dump into multiple task

add more log to indicate progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants