Skip to content

Conversation

@peilun-conflux
Copy link
Contributor

@peilun-conflux peilun-conflux commented Jan 6, 2026

parity-crypto has been deprecated.

Most codes are directly from parity-crypto, while some are adjusted because the latest version of the dependencies have different interfaces.


This change is Reviewable

Copy link
Member

@Pana Pana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pana reviewed 30 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ChenxingLi and @peilun-conflux).


crates/cfx_key/Cargo.toml line 11 at r1 (raw file):

[dependencies]
cfx-types = { workspace = true }
cfx-crypto = { path = "../cfx_crypto" }

same here


crates/execution/executor/Cargo.toml line 13 at r1 (raw file):

byteorder = { workspace = true }
cfxkey = { workspace = true }
cfx-crypto = { path = "../../cfx_crypto" }

recommend use workspace style


crates/network/Cargo.toml line 11 at r1 (raw file):

cfx-bytes = { workspace = true }
cfx-types = { workspace = true }
cfx-crypto = { path = "../cfx_crypto" }

same here

Copy link
Contributor Author

@peilun-conflux peilun-conflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peilun-conflux made 3 comments.
Reviewable status: 25 of 30 files reviewed, 3 unresolved discussions (waiting on @ChenxingLi and @Pana).


crates/cfx_key/Cargo.toml line 11 at r1 (raw file):

Previously, Pana (Pana) wrote…

same here

Done.


crates/execution/executor/Cargo.toml line 13 at r1 (raw file):

Previously, Pana (Pana) wrote…

recommend use workspace style

Done.


crates/network/Cargo.toml line 11 at r1 (raw file):

Previously, Pana (Pana) wrote…

same here

Done.

Copy link
Member

@Pana Pana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pana reviewed 11 files and all commit messages, and resolved 3 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ChenxingLi).

@Pana Pana merged commit e29742f into master Jan 22, 2026
11 checks passed
@peilun-conflux peilun-conflux deleted the rm_parity_crypto branch January 22, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants