-
Notifications
You must be signed in to change notification settings - Fork 213
chore: remove dependency of parity-crypto
#3370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pana reviewed 30 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ChenxingLi and @peilun-conflux).
crates/cfx_key/Cargo.toml line 11 at r1 (raw file):
[dependencies] cfx-types = { workspace = true } cfx-crypto = { path = "../cfx_crypto" }
same here
crates/execution/executor/Cargo.toml line 13 at r1 (raw file):
byteorder = { workspace = true } cfxkey = { workspace = true } cfx-crypto = { path = "../../cfx_crypto" }
recommend use workspace style
crates/network/Cargo.toml line 11 at r1 (raw file):
cfx-bytes = { workspace = true } cfx-types = { workspace = true } cfx-crypto = { path = "../cfx_crypto" }
same here
peilun-conflux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peilun-conflux made 3 comments.
Reviewable status: 25 of 30 files reviewed, 3 unresolved discussions (waiting on @ChenxingLi and @Pana).
crates/cfx_key/Cargo.toml line 11 at r1 (raw file):
Previously, Pana (Pana) wrote…
same here
Done.
crates/execution/executor/Cargo.toml line 13 at r1 (raw file):
Previously, Pana (Pana) wrote…
recommend use workspace style
Done.
crates/network/Cargo.toml line 11 at r1 (raw file):
Previously, Pana (Pana) wrote…
same here
Done.
Pana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pana reviewed 11 files and all commit messages, and resolved 3 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ChenxingLi).
parity-cryptohas been deprecated.Most codes are directly from
parity-crypto, while some are adjusted because the latest version of the dependencies have different interfaces.This change is