Skip to content

upgrade go-conflux-sdk#93

Merged
Tigo9527 merged 3 commits intomainfrom
upgrade-sdk
Jan 13, 2026
Merged

upgrade go-conflux-sdk#93
Tigo9527 merged 3 commits intomainfrom
upgrade-sdk

Conversation

@Tigo9527
Copy link
Contributor

@Tigo9527 Tigo9527 commented Jan 13, 2026

This change is Reviewable

@Tigo9527 Tigo9527 requested review from boqiu and wanliqun January 13, 2026 02:35
Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boqiu reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Tigo9527 and @wanliqun).


blockchain/sync/evm/adapter.go line 106 at r1 (raw file):

	if err := data.queryBlock(adapter.client, bn); err != nil {
		return BlockData{}, errors.WithMessage(err, fmt.Sprintf("Failed to query block at %d", blockNumber))

Unnecessary, it's up to the caller to print out the block number.


blockchain/sync/core/adapter.go line 125 at r1 (raw file):

	if err := data.queryBlocks(adapter.client, blockNumber); err != nil {
		return EpochData{}, errors.WithMessage(err, fmt.Sprintf("Failed to query epoch blocks at %d", blockNumber))

Unnecessary, it's up to the caller to print out the requested block number

@Tigo9527 Tigo9527 requested a review from boqiu January 13, 2026 02:44
Copy link
Contributor Author

@Tigo9527 Tigo9527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Removed.

@Tigo9527 made 3 comments.
Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @boqiu and @wanliqun).


blockchain/sync/core/adapter.go line 125 at r1 (raw file):

Previously, boqiu (Bo QIU) wrote…

Unnecessary, it's up to the caller to print out the requested block number

Ok, Removed.


blockchain/sync/evm/adapter.go line 106 at r1 (raw file):

Previously, boqiu (Bo QIU) wrote…

Unnecessary, it's up to the caller to print out the block number.

Ok, Removed.

Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boqiu reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wanliqun).

@Tigo9527 Tigo9527 merged commit 26e392d into main Jan 13, 2026
2 checks passed
@Tigo9527 Tigo9527 deleted the upgrade-sdk branch January 13, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments