Conversation
boqiu
left a comment
There was a problem hiding this comment.
@boqiu reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Tigo9527 and @wanliqun).
blockchain/sync/evm/adapter.go line 106 at r1 (raw file):
if err := data.queryBlock(adapter.client, bn); err != nil { return BlockData{}, errors.WithMessage(err, fmt.Sprintf("Failed to query block at %d", blockNumber))
Unnecessary, it's up to the caller to print out the block number.
blockchain/sync/core/adapter.go line 125 at r1 (raw file):
if err := data.queryBlocks(adapter.client, blockNumber); err != nil { return EpochData{}, errors.WithMessage(err, fmt.Sprintf("Failed to query epoch blocks at %d", blockNumber))
Unnecessary, it's up to the caller to print out the requested block number
Tigo9527
left a comment
There was a problem hiding this comment.
Ok, Removed.
@Tigo9527 made 3 comments.
Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @boqiu and @wanliqun).
blockchain/sync/core/adapter.go line 125 at r1 (raw file):
Previously, boqiu (Bo QIU) wrote…
Unnecessary, it's up to the caller to print out the requested block number
Ok, Removed.
blockchain/sync/evm/adapter.go line 106 at r1 (raw file):
Previously, boqiu (Bo QIU) wrote…
Unnecessary, it's up to the caller to print out the block number.
Ok, Removed.
boqiu
left a comment
There was a problem hiding this comment.
@boqiu reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @wanliqun).
This change is