Skip to content

Conversation

@ConnectedSystems
Copy link
Owner

@ConnectedSystems ConnectedSystems commented Nov 15, 2025

PR addresses bugs, improves code cleanliness, and enhances functionality across multiple modules.

  • It fixes issues related to irrigation, costing, and result collation.
  • Enhancements focus on more accurate calculations, better handling of edge cases, and improved code readability.

Specifically, it:

  • Corrects handling of irrigation efficiency, ensuring accurate water application and reporting.
  • Refines pump cost calculations by using head pressure and fixes field area accounting in cost calculations.
  • Implements fixes in result collation, including zero division and single scenario handling.
  • Updates and corrects docstrings and variable names for improved code clarity.
  • Modifies capital costs related to groundwater bores to more reasonable values

This improves the accuracy and robustness of the model.

In figure below, the blue line represents default config.
The gold line was a scenario run with no capital costs, no pumping costs, and a 99% efficient gravity irrigation system

image

Assume variable costs cover seed, fertiliser, herbicides, harvesting costs, etc.
Otherwise there is a chance that 0 values get returned
Account for irrigation efficiency

Also update variable names for readability
Years where crops are not cultivated should still incur some operational/maintenance costs
Unfinished, still sorting out issues with costs
@ConnectedSystems ConnectedSystems added bug Something isn't working documentation Improvements or additions to documentation labels Nov 15, 2025
@ConnectedSystems ConnectedSystems merged commit c658488 into main Nov 15, 2025
1 check failed
@ConnectedSystems ConnectedSystems deleted the cleanup-and-bugs branch November 15, 2025 13:40
@ConnectedSystems ConnectedSystems mentioned this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants