Fix 'Bare node creation' test of IHACRESExpuhNode #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'Bare node creation' test was returning an error when passing an
expuh: `MethodError: no method matching unsafe_convert(::Type{Float64},
::Int64)`. This happened because tau_s value was an integer and should
be a float. This commit change the default value of tau_s from 5 to 5.0.
The "Bare node creation" test using IHACRESExpuhNode is returning an error: `MethodError: no method matching update_state`. This is happening because the commit 775a575 changed the definition of some methods and not all usage of them have changed. It adds a "!" to the update_state method on IHACRESExpuhNode.jl.
Owner
|
Hi @vitorhirata Thanks for this. Yes, if you already have a fix in hand, I prefer a PR be submitted directly rather than an issue and a PR. Otherwise, it splits the discussion into two locations. I have a number of big changes planned which is why I wasn't fussed about tests failing at this time. One of which may be to restructure IHACRES so the different formulations are more modular. The changes in this PR look fine in any case, so I'll merge when CI finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two errors on the 'Bare node creation' test of IHACRESExpuhNode
MethodError: no method matching unsafe_convert(::Type{Float64}, ::Int64). This happened becausetau_svalue was an integer and should be a float. The PR changes the default value of tau_s from 5 to 5.0.MethodError: no method matching update_state. This is happening because the commit 775a575 changed the definition of some methods, and not all usage of these methods has changed. The PR changes two calls toupdate_statetoupdate_state!.@ConnectedSystems let me know if this makes sense. I went straight to creating a PR and not an issue because it seemed like a simple change, but let me know if you'd prefer something else.