Changed 'featureBounds' method to use 'forEachLatLng'#3
Open
peteroomen wants to merge 1 commit intoConnum:masterfrom
Open
Changed 'featureBounds' method to use 'forEachLatLng'#3peteroomen wants to merge 1 commit intoConnum:masterfrom
peteroomen wants to merge 1 commit intoConnum:masterfrom
Conversation
Owner
|
Sorry for not reacting to this yet. I didn'd have the time for looking into this so far, as I'm not currently working on the project for which I created this fork. As soon as I pick that up, I'll give it a try and see if it breaks anything for me. Thanks for the contribution, appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a change to the 'featureBounds' function, so it would support complex geometries, with more than one level of nesting. It was only traversing one layer of the Geometry's points, when in fact Geometries can have any amount of nesting. One example of complex geometries of this type is the 'MultiPolygon' https://tools.ietf.org/html/rfc7946#section-3.1.7
My change to the function makes it use google's forEachLatLng method, provided for geometries. This method iterates over each LatLng of a geometry, regardless of what kind of geometry it is, and how many layers of geometries and points it contains. I use this method to extend the bounds using each LatLng inside the Geometry.